Repository navigation
PIQ-5878: Remove fallback origins and company names, release 1.3.3 - #47
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alex-piq
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debranding for the card-entry SDK, part of the client debranding epic (PIQ-5868). It removes every clear company name from the published package and changes one behaviour: origin validation now trusts only the origin of the configured
hostedfieldsurl.Merging publishes 1.3.3 to npm (
build_and_publish.yamlrunsnpm publishon every push tomaster).Jira: https://paymentiq.atlassian.net/browse/PIQ-5878
Changes
src/sdk/api/index.js:validateOrigindrops the two built-in fallback origins (test-hostedpages.paymentiq.ioandcard-fields.paymentiq.io).setup()already adds the origin ofhostedfieldsurlto the allowed list, and the SDK loads the iframes from that same URL and posts to that origin. So the fallbacks could only matter for an integration whose iframes load from a different host thanhostedfieldsurl, and that integration would never receivesetupContentanyway.package.json: removesauthor,repository,bugs,homepageand the Bambora/Devcode keywords, following the PIQ-5871 precedent in the bootstrapper. Adds"files": ["dist", "index.d.ts"], soCHANGES.md(with its GitHub links),.github/and.nvmrcno longer ship. Version bumped to 1.3.3, inpackage-lock.jsontoo.README.md: the example URLs becomehttps://<hosted-fields-host>/<version>/index.html, with "your account manager provides the host". The migration notices, the stale version list and the "Notes" section are removed. It adds one sentence telling integrators that messages are accepted only from the origin ofhostedfieldsurl, because the changelog no longer ships and the npm page is the only place they will see this. The released versions now live in the Docs Portal guide.CHANGES.md: 1.3.3 entry, including the behaviour change.dist/: rebuilt withnpm run buildon Node 20.12.2. On cleanmasterthe same build reproduces the committeddist/byte for byte, so the onlydist/change isvalidateOrigin.The npm maintainer stays
devcodepayment: that is an npm account setting, and a neutral npm organisation is PIQ-5870. A build-time brand guard for this repo is left to PIQ-5877.Verification
npm packof 1.3.3 ships 11 files (README, package.json, index.d.ts, dist). A case-insensitive search of all of them finds no paymentiq, worldline, devcode or bambora. The same search on 1.3.2 fails./creditcard/deposit/validatewith the iframe's field data, which shows the SDK accepted the iframe's message.Linked PRs and merge order
PIQ-5878 spans four repos. Merge in this order:
^1.3.3and removes the PIQ-5878 allowance from the brand-bundle guard, which is what stops the two hosts shipping in V3 builds.🤖 Generated with Claude Code