Repository navigation
Add fish shell completion - #69
Open
montionugera wants to merge 1 commit into
Open
montionugera wants to merge 1 commit into
montionugera wants to merge 1 commit into
Conversation
- Add completions/btc-toolkit.fish with subcommands and flags mirroring btc-toolkit.zsh - Extend tests/test_completions.py to ensure fish completions match build_parser() - Mention fish in README.md shell completion docs and architecture overview - Update CHANGELOG.md under [Unreleased] Closes devdavidejesus#62
Owner
|
Thanks a lot for this, and welcome! It's the project's first outside contribution. I tested it in a real fish shell (3.7.0): all 11 commands, their flags and the networks complete correctly, and the tests pass. Two small changes before I merge:
Then I'll merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds static fish shell completions (
completions/btc-toolkit.fish) mirroringcompletions/btc-toolkit.zshfor all 11 subcommands and their supported flags, extendstests/test_completions.pyto ensure fish completions stay synchronized withbuild_parser(), and documents fish completion inREADME.mdandCHANGELOG.md.Closes #62
Checklist
tests/(unittest, API calls mocked, runs offline)python -m coverage run -m unittest discover -s tests -t .thenpython -m coverage report(90% or more)ruff check btc_toolkit/ tests/ fuzz/ .github/scripts/andmypy --strict btc_toolkit/passfuzz/fuzz_parsers.py--jsonkeys only added, never renamed or removed (docs/json-schema.md)[Unreleased]inCHANGELOG.md