Fix classification repair for conversation history requests - #55
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Asking to list the user messages in an existing conversation failed during classification, before the context finalizer ran. The classifier used automatic tool selection for both attempts, so a response without a routing call could repeat on repair and fail with
Invalid fields: tool call.Require the classify_request tool on repair when the first response lacks exactly one routing call. Keep automatic selection for the initial attempt and argument-only repairs because forcing every call previously produced incomplete arguments. Continue validating the full routing schema; ordinary prose is never accepted as a decision.
Explicitly support requests to list, quote, summarize, or correct conversation messages. Tell the finalizer to list available user messages chronologically, including the current request, and disclose the eight-completed-turn context boundary. Add a distinct diagnostic for missing or multiple routing calls.
Validation
The two production failures were confirmed in Chrome. Raw production model outputs were unavailable, so the test reproduces the missing-tool-call failure mode rather than claiming to replay a captured provider response. Changes are not deployed.