Skip to content

Fix classification repair for conversation history requests - #55

Merged
devhims merged 1 commit into
mainfrom
fix/conversation-classification-repair
Sep 18, 2026
Merged

devhims merged 1 commit into
mainfrom
fix/conversation-classification-repair

Conversation

@devhims

@devhims devhims commented Sep 18, 2026

Copy link
Copy Markdown
Owner

Summary

Asking to list the user messages in an existing conversation failed during classification, before the context finalizer ran. The classifier used automatic tool selection for both attempts, so a response without a routing call could repeat on repair and fail with Invalid fields: tool call.

Require the classify_request tool on repair when the first response lacks exactly one routing call. Keep automatic selection for the initial attempt and argument-only repairs because forcing every call previously produced incomplete arguments. Continue validating the full routing schema; ordinary prose is never accepted as a decision.

Explicitly support requests to list, quote, summarize, or correct conversation messages. Tell the finalizer to list available user messages chronologically, including the current request, and disclose the eight-completed-turn context boundary. Add a distinct diagnostic for missing or multiple routing calls.

Validation

  • Regression test reproduced the exact error before the fix and passes afterward, exercising a prose response followed by a required routing call.
  • 594 local tests passed.
  • Platform TypeScript build and git diff --check passed.
  • Added an opt-in live classifier regression. The live attempt was blocked by automatic approval review before execution, so provider behavior has not been verified.

The two production failures were confirmed in Chrome. Raw production model outputs were unavailable, so the test reproduces the missing-tool-call failure mode rather than claiming to replay a captured provider response. Changes are not deployed.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
video2ctx-web Ready Ready Preview Sep 18, 2026 11:40am UTC

@devhims
devhims merged commit 33959c8 into main Sep 18, 2026
6 checks passed
@devhims
devhims deleted the fix/conversation-classification-repair branch September 18, 2026 11:44

This branch was successfully deployed

1 active deployment
Preview 85bb48ec Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant