Skip to content

Fix restored answer formatting and constrain finalizer citations - #60

Merged
devhims merged 1 commit into
mainfrom
fix/session-restoration-finalization
Sep 19, 2026
Merged

devhims merged 1 commit into
mainfrom
fix/session-restoration-finalization

Conversation

@devhims

@devhims devhims commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Restored session messages exposed internal [cite:evidence:...] markers because they bypassed the formatter used by live run responses. Restoration now uses the same numbered-reference projection, while canonical answers and user messages remain unchanged.

Finalization accepted arbitrary strings as evidence IDs and could exhaust its repair attempt with invalid citations after successful frame analysis. After context gathering, its structured-output schema now limits answer and memory references to supplied excerpt IDs and aliases. Persisted-evidence validation remains authoritative. Citation failures additionally log whether evidence was missing or conflicting, without logging the identifier or answer.

Validation:

  • 623 unit tests passed, 7 skipped.
  • 67 local Cloudflare Durable Object integration tests passed, including a regression comparing restored messages with compact progress responses and checking unchanged storage.
  • Platform TypeScript check passed.
  • Chrome dashboard refresh/Markdown test passed.
  • Five live Fireworks finalizer checks passed with a fixed finalization route and entirely synthetic data: three saved-frame descriptions, one transcript answer, and exact first-message retrieval. These are schema compatibility checks, not a production replay or reliability benchmark. The local harness and production diagnostics are excluded from this PR.

The reported run's logs confirm two normally completed model responses rejected at citation validation. They do not retain the rejected identifier, so this change does not claim to reconstruct the exact bad reference.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
video2ctx-web Ready Ready Preview Sep 19, 2026 2:13pm UTC

@devhims
devhims merged commit 7f9d705 into main Sep 19, 2026
6 checks passed
@devhims
devhims deleted the fix/session-restoration-finalization branch September 19, 2026 14:23

This branch was successfully deployed

1 active deployment
Preview 81e4daf9 Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant