Fix comparison scope and reserve 60 seconds for finalization - #62
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up video comparisons could lose the earlier subject, exceed the final answer token limit, and exhaust the shared deadline during repair. The fallback then displayed arbitrary, sometimes repeated transcript fragments as a completed partial answer.
This change preserves explicit comparison subjects independently of the video needing retrieval. The finalizer loads saved transcripts for every subject without provider calls, validates source coverage, and reports both subjects in coverage. Named comparisons skip discovery. Citation aliases are applied before measuring the context budget, and oversized transcripts retain sampled passages across their timeline with an explicit coverage warning.
Finalization now has a persisted 60-second deadline. Context gathering is bounded to 10 seconds, and the first synthesis attempt reserves up to 20 seconds for one repair. Structured output allows 3,000 standard or 4,000 detailed tokens, with another 1,000 on repair, plus the existing reasoning allowance. Recovery and cancellation retain the original deadline.
Fallback results preserve deduplicated analyzed findings or visual observations. Raw transcript fragments no longer substitute for an answer; without useful findings the run fails clearly and saved assets remain reusable. Failed and partial responses explain output-limit exhaustion, finalization timeouts, or answer-validation failures and retain retry guidance. An output-limit failure followed by a repair timeout preserves both causes. Partial answers display an alert above the findings and retain the cause in saved text after refresh.
Validation: