fix: trust deployed Vercel preview hosts - #68
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Intent: Allow only the actual video2ctx Vercel project previews to complete the production OAuth proxy flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Google sign-in from PR #67's Vercel preview fails before reaching Google. Production trusts preview hosts beginning with
all-things-youtube-web, but the deployed Vercel project usesvideo2ctx-weband thedevhims-projectsteam suffix.Why it matters
Every real Vercel preview receives 403
Invalid callbackURL, so the OAuth proxy cannot be tested or used before merge.What changed
The approved host pattern is now
video2ctx-web-*-devhims-projects.vercel.app. This matches the real project and team while continuing to reject unrelated Vercel applications.The Workers integration fixture now uses the exact PR #67 deployment hostname.
Tests
Invalid callbackURL.Manual verification
Merge this PR and wait for the production Worker deployment. Then retry Google sign-in from the PR #67 preview.
Screenshots / video
Not applicable. This changes the server-side callback allowlist without changing rendered UI.
Issue link
no linked issue: fixes preview authentication discovered while testing PR #67.