Furnish schemas and release Relay 0.2.1 - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
I went through Relay once more from the perspective of somebody installing the public wheel rather than developing from a checkout. The missing piece was concrete integration contracts: the report declared schema version 2.0, but Relay could not yet hand an editor or CI job the schema itself.
This patch release:
relay.tomlconfiguration;relay schema reportandrelay schema config, including atomic--output;pathspec>=0.12,<2dependency update from Update pathspec requirement from <1,>=0.12 to >=0.12,<2 #11;Oh! I kept Relay itself as the final configuration validator, because cross-field checks such as aggregate versus per-file limits should not be weakened just to fit a schema.
User impact
An installed Relay wheel can now furnish the exact schemas needed by editors and automation. Trying the README commands no longer leaves a dirty checkout, and current
pathspec1.x releases install without artificial resolver conflicts.Validation
pathspec 1.1.1passed the full local suitepip check, version, schema, corpus JSON, timing summary, and doctor smoke tests passedCloses #6