#2351: Fixed GUI not launching with local dev build

[samuelkos17]

This PR fixes #2351

Implemented changes:

• Problem 1: Unresolved $[project.version] in the installed gui/pom.xml
  • Cause: The script copied the raw cli/src/main/package directory into the local-dev installation, bypassing Maven's resource filtering. As a result the launcher gui/pom.xml kept the literal $[project.version] placeholder instead of the resolved version, so ide gui tried to resolve a non-existent artifact and failed.
  • Fix: copy the filtered build output (cli/target/package) instead of the raw source. This matches how the release assembly assembles the package.
• Problem 2: GUI resolved from the wrong source
  • Cause: build-local-dev.sh only built the CLI and never built the GUI. But ide gui doesn't build the GUI from source — it runs Maven against the installed gui/pom.xml, which declares a dependency on the ide-gui snapshot and resolves it from the local maven repository. So ide gui launched whatever ide-gui snapshot happened to be cached/remote (e.g. from another branch), not the one built here.
  • Fix: install the gui module (and the CLI, so ide-cli resolves) into the local maven repository.
• Additional cleanup:
  • Add clean so stale build output from another branch/checkout can't leak into the local-dev installation.
  • Use -f <pom> for both Maven invocations instead of cd, so the build is independent of the caller's working directory.

---

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1. Run ./build-local-dev.sh
2. Open a shell and run ide gui. The GUI should open.

---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summaries what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
  with internal
• You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
• You have formulated clear instructions on how to test your contribution under "Testing instructions"

[coveralls]

Coverage Report for CI Build 32373432172

Coverage remained the same at 72.944%

Details

• Coverage remained the same as the base build.
• Patch coverage: No coverable lines changed in this PR.
• 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	78.69%

---

Coverage Stats

Relevant Lines:	17567
Covered Lines:	13364
Line Coverage:	76.07%
Relevant Branches:	7769
Covered Branches:	5117
Branch Coverage:	65.86%
Branches in Coverage %:	Yes
Coverage Strength:	3.23 hits per line

---

💛 - Coveralls

[krystynaShatkovska]

Hi, i checked fixes, they work, well done. The only thing i want to recommend is to do both steps (the build script and ide gui) inside the same ide shell. That way both use the same cache folder. Because maven keeps downloaded libraries in a local folder, and which folder it uses is decided by an environment variable (M2_REPO) that is only set inside an ide shell (via conf/mvn/settings.xml). So if the two steps happen in different shells, the fix can silently not work. Then ide gui doesn't find your local GUI and quietly falls back to the remote snapshot. The GUI opens anyway but so it looks like the fix works, but it's launching the wrong build.

[samuelkos17]

@krystynaShatkovska did you test that and experienced that problem or are you just saying that it could happen? If you did experience this, then the fix isn't really that useful

[krystynaShatkovska]

Yes, I tested it. The fix works with a local install, ide gui launches the locally built GUI, not the remote one. About next, the two shell types really point Maven at two different folders (ide shell to conf/mvn/repository, plain shell to ~/.m2). If the build runs in a plain shell and ide gui in an ide shell, the two use different repos, so ide gui silently falls back to the remote GUI. So maybe you can think about adding just one line in the testing instructions: run both steps in the same ide shell, so a tester on a fresh shell doesn't get a false

[samuelkos17]

@krystynaShatkovska I couldn't reproduce your problem, could you please explain step by step how you've encountered this issue? I've run the build-local-dev.sh script in a normal shell and when i opened a new shell everything worked perfectly fine. I also did the same using the ide shell and everything worked perfectly fine.