Precompute reverse dependency graph for diff-mode change-impact analysis - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cis changed modules andEis import edges.Description
reverseDependencies()tomoduleGraphto build a reverse adjacencymap[string][]stringonce after graph construction.reverse := item.graph.reverseDependencies()once pertargetModuleGraphinchangeImpactFindingsand reuse it for all changed files.changeImpactEntryto acceptreverse map[string][]stringand usesupport.TransitiveDependents(reverse, module)to derive dependents.Testing
go test ./internal/codeguard/checks/design ./tests/checksand the targeted tests completed successfully.go test ./...and the full test suite completed successfully.gofmtandgit diff --checkto ensure formatting and no diff-check issues and they passed.Codex Task