Scope nullable block guard detection to the matched guard body - #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
if (!name) {and could credit an exit keyword that occurred outside the guard block, producing false negatives fordefensive.null-assumption.Description
nullableParamHasBlockExitGuardwith brace-depth tracking so the function locates the matching}and only searches forreturn|throw|continue|breakinside that exact block ininternal/codeguard/checks/quality/quality_defensive.go.nullableParamGuardedwhile making the block-style check conservative for unclosed blocks.internal/codeguard/checks/quality/quality_defensive_test.gothat validate exits inside the guard, exits after the guard (should not count), nested guard exits, and unclosed guard behavior.Testing
go test ./internal/codeguard/checks/quality ./tests/checksand the test suites completed successfully, including the new regression test file (tests passed).go test ./internal/codeguard/checks/qualityto verify the package-level tests and the new unit tests, which passed.szrwrapper was recommended by local AGENTS.md but was not available in the execution environment, so tests were run with the standardgo testcommand.Codex Task