chore(crypto): remove stale unused_assignments allow - #11472
Merged
Merged
Conversation
…147648 fixed upstream) The #![allow(unused_assignments)] and its TODO were added as a workaround for a rustc false-positive (rust-lang/rust#147648) when IC upgraded to rustc 1.92.0. That bug was fixed upstream in rust-lang/rust#151556, shipped in Rust 1.94.0/1.95.0, and IC's pinned toolchain is now 1.97.1. cargo check confirms no unused_assignments diagnostics are emitted without the suppression, so it is safe to remove. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kWotpWN6DJC8SWj5qriBK
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped cleanup removes a compiler workaround that is no longer needed and does not alter runtime behavior.
Pull request overview
Removes an obsolete Rust compiler-lint workaround from the Groth20 BLS12-381 NI-DKG types module.
Changes:
- Removes the stale
unused_assignmentsallowance. - Removes its associated TODO comment.
File summaries
| File | Description |
|---|---|
rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/src/ni_dkg/groth20_bls12_381/types.rs |
Removes the obsolete module-level lint suppression. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nmattia
marked this pull request as ready for review
September 7, 2026 12:14
nmattia
enabled auto-merge
September 7, 2026 12:14
pierugo-dfinity
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Nicolas Mattia · Slack thread
Before
rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/src/ni_dkg/groth20_bls12_381/types.rscarried a module-level#[allow(unused_assignments)]plus a TODO comment, added as a workaround for a rustc false-positive (rust-lang/rust#147648) when IC upgraded to rustc 1.92.0 in #8124 (Jan 2026).After
The suppression and TODO are removed: the underlying compiler bug (rust-lang/rust#147648, now closed) was fixed upstream in rust-lang/rust#151556 and shipped in Rust 1.94.0/1.95.0. IC's pinned toolchain (
rust-toolchain.toml) is now 1.97.1, well past the fix.cargo check --all-targets --all-features -p ic-crypto-internal-threshold-sig-bls12381and a crate-scopedcargo clippywith the repo's lint flags confirm nounused_assignmentsdiagnostics are emitted without the allow, so the suppression is stale.🤖 Generated with Claude Code
https://claude.ai/code/session_016kWotpWN6DJC8SWj5qriBK