Skip to content

Bump egui group - #262

Merged
insolor merged 5 commits into
mainfrom
bump-egui-group
Oct 9, 2026
Merged

insolor merged 5 commits into
mainfrom
bump-egui-group

Conversation

@insolor

@insolor insolor commented Oct 9, 2026 •

Copy link
Copy Markdown
Member
  • Bumbed egui dependencies, fix build errors
  • Format code, add code formatting check
  • Add some docs by CodeRabbit

Summary by CodeRabbit

  • User Interface
    • The status bar now has a 25-pixel default and minimum height and can expand to fill available space.
    • Confirmation and warning dialogs retain their existing messages and choices.
  • File Selection
    • The open-file dialog now starts in the selected directory or the current working directory, rather than using the previously opened file as its initial path.
  • Build Quality
    • Builds now check code formatting across supported operating systems.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 169b3e73-a513-4759-a93f-19dba8519d0c

📥 Commits

Reviewing files that changed from the base of the PR and between 612aaaa and 1a7600a.


📒 Files selected for processing (3)
  • src/app.rs
  • src/fetch.rs
  • src/logic.rs

🚧 Files skipped from review as they are similar to previous changes (3)
  • src/logic.rs
  • src/fetch.rs
  • src/app.rs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The pull request upgrades egui-related dependencies and adapts the application UI and dialogs to updated APIs. It also changes the base-URL index update operation and adds a formatting check to the build workflow.

Changes

egui application migration

Layer / File(s) Summary
Dependency upgrade and UI rendering
Cargo.toml, src/app.rs, .github/workflows/build.yml, src/localization.rs, src/thread_pool.rs
egui-related dependencies are upgraded. The application uses the updated UI callback, context, and panel APIs. The build workflow runs cargo fmt --check. Imports are reordered in src/localization.rs and src/thread_pool.rs.
File and modal dialogs
src/logic.rs
The open-file dialog no longer receives the current file as its initial file. Warning and confirmation dialogs use egui::Modal. Their buttons retain their callbacks, and the explicit modal open and close calls are removed.

Base-URL index update

Layer / File(s) Summary
Base-URL index update
src/fetch.rs
switch_to_next_base_url uses AtomicUsize::try_update instead of fetch_update. The update closure and its limit remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 1a760

No actionable merge-blocking issue is established by the supplied evidence; the PR is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 55.56% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the main change: updating the egui dependency group and related code to newer APIs.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@insolor
insolor marked this pull request as ready for review October 9, 2026 07:19
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🤖 Completed: Fix pre-merge checks in PR #262 — View commit 1a7600a

@insolor
insolor merged commit ee52644 into main Oct 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant