docs: PI disaggregation categoryCombo note and section cleanup (DHIS2-18745) - #1776
Draft
karolinelien wants to merge 7 commits into
Draft
docs: PI disaggregation categoryCombo note and section cleanup (DHIS2-18745)#1776karolinelien wants to merge 7 commits into
karolinelien wants to merge 7 commits into
Conversation
… (DHIS2-18745) When setting up Program Indicator disaggregation directly via the metadata API instead of through the Maintenance app, the Program Indicator's own categoryCombo/attributeCombo must also be set to a Category Combination containing the mapped category, or the mapping won't display or be editable in this screen even though it still works in analytics. AI Assisted
…isaggregation section (DHIS2-18745) Corrects several issues in the program disaggregation mappings walkthrough found while cross-checking it against the Maintenance (Preview) app source: the section is actually grouped under "Programs" in the sidebar, not "Other". Also fixes broken step numbering, a typo, inconsistent Visualizer/visualization spelling, sizes the oversized retina screenshots consistently with the rest of the page, and adds notes on save-time mapping validation and the aggregate-export ID fields. AI Assisted
…IS2-18745) The app was renamed from "Maintenance (Preview)" to "Metadata Management" (metadata-management-app commit 77821e6, DHIS2-21090), which also changed its URL slug from maintenance-preview to metadata-management. Updates the PI disaggregation walkthrough to match. AI Assisted
karolinelien
marked this pull request as ready for review
August 5, 2026 13:32
DavidCKen
requested changes
Aug 6, 2026
DavidCKen
left a comment
DavidCKen
left a comment
Contributor
There was a problem hiding this comment.
The link I highlighted should be relative to the anchor, the wrong format was already in the file. and a lot of the screenshots should be changed to show the MMA not the maintenance app preview, do you want to do that in a combined PR or seperate?
… validation (DHIS2-18745) Expands the existing categoryCombo note after confirming against dhis2-core (ProgramCategoryMappingValidator / PiDisagInfoInitializer) that neither completeness nor duplicate-categoryId mappings are checked when a Program or Program Indicator is created/updated via the API - both only surface at analytics query time, and a categoryId collision currently crashes with an unhandled server error rather than a validation message. The Maintenance (Preview)/Metadata Management screen prevents this; the API does not. AI Assisted
…(DHIS2-18745) Per David's review comment on #1776: the target section already exists in this same book, so the link should be a relative anchor instead of an external versioned docs.dhis2.org URL. AI Assisted
Contributor
Author
|
Doing this as a combined PR - I'll swap the outdated Maintenance (Preview) screenshots for the current Metadata Management app in this same PR rather than splitting it out. |
…anagement app (DHIS2-18745) Per David's review comment on #1776: the old screenshots showed the Maintenance (Preview) app's outdated branding/layout. Recaptured all screens against the public play.im.dhis2.org/dev demo (2.44-SNAPSHOT), which already has this exact walkthrough configured (Inpatient morbidity and mortality program, BMI PI, Gender + Morbidity Age disaggregation). Screenshots are now taken at the README's recommended 1440x900 instead of the old 2x-retina captures. Also drops the .center width=60% override on the filter-expression dialog screenshot in favor of the standard full-width treatment used elsewhere in this section. AI Assisted
…live (DHIS2-18745) The previous screenshot pass used a demo instance where BMI already had a finished disaggregation mapping configured, so the images didn't match the doc's step-by-step "empty -> filled" narrative (e.g. showing an already- selected category combo instead of the "No mappings available" state the text describes). Redone against design.im.dhis2.org/release-43, which had no disaggregation set up on this program at all. Actually walked through the documented steps: created the missing "Gender and U5y" category combo (the doc's own text says to do this if not present), added BMI, added both suggested categories, and filled in the same filter expressions the text describes (Gender ==/=='Female'/'Male', age </>=5). Screenshots now show the correct before/after state at each step instead of a pre-finished result. AI Assisted
karolinelien
marked this pull request as draft
August 11, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
categoryCombo/attributeCombomust also include the mapped Category, or the mapping won't show/be editable in the Maintenance app screen (though it still works in analytics)default)Test plan
#data_exchangeanchor, external JEXL reference) resolve correctly in the built siteAI Assisted