Repository navigation
ci(release): run the checks before a tag publishes anything - #87
Merged
Merged
Conversation
The release workflow starts on any `v*` tag and went straight to building and publishing binaries, the chart and the images. A tag can be pushed on any commit, so a release could be published from code CI never checked. A `verify` job now runs gofmt, vet, the Go tests (default and experimental builds) and the Helm lint, and the `binaries` and `images` jobs need it. Not verified: the workflow runs only when a tag is pushed. The YAML parses and the make targets it calls pass locally. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Jalil <reachjalil@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
The release workflow runs the checks before it publishes anything.
What problem does it solve?
release.ymlstarts on anyv*tag and went straight to building and publishing binaries, the chart and the images. A tag can be pushed on any commit, so a release could be published from code CI never checked.How is it implemented?
A new
verifyjob runsmake fmt-check vet test experimentalandmake helm-lint. Thebinariesandimagesjobsneedit, so a failing check publishes nothing.It does not check which branch the tag is on, and it does not run the SDK tests; both could be added.
How was it tested?
verifywith no needs andbinaries/imagesneeding it.Checklist
make verifypasses (no code changed)git commit -s)api/openapi.yaml, both SDKs anddocs/feature-parity.md(no API change)🤖 Generated with Claude Code