Repository navigation
feat(app): find text on a settings page - #7416
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Long settings pages such as Advanced are hard to scan for one option, and Cmd/Ctrl+F did nothing there. Behind `settingsFind` (cloud and self-hosted, off): - Cmd/Ctrl+F, a find button in the settings header, or "Find on this page" in the command palette opens a find field over the page. It highlights every match, counts them and steps through them with Enter and Shift+Enter; Esc closes it. Another settings page is searched again for the same text. - Matches are ranges painted with the CSS Custom Highlight API (find-matches.ts, find-highlights.ts), so the page's own nodes are never changed and React keeps owning them. The marks "Find in conversation" inserts would break pages React re-renders. - Hidden text, screen-reader-only labels and the find field itself are not searched. - Settings shown beside a chat share the shortcut with "Find in conversation": the page takes it only while focus is inside settings. The find field is the conversation find bar's markup moved to components/find-field.tsx; SessionFindBar renders it unchanged. Signed-off-by: Jalil <reachjalil@gmail.com>
reachjalil
force-pushed
the
feat/find-in-settings-page
branch
from
November 14, 2026 01:01
2bb34d4 to
344fde4
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Settings pages can be searched: Cmd/Ctrl+F, or a find button in the settings header, finds text on the open page.
What problem does it solve?
Long settings pages such as Advanced are hard to scan for one option.
What was the situation before?
Cmd/Ctrl+F did nothing in Settings. Finding an option meant scrolling the whole page and reading it.
How is this implemented?
settingsFind(cloud and self-hosted, off). Safe to kill: the field closes and nothing is stored. Doc and screenshot:docs/features/settings-find/README.md.domains/settings/find/: matches are ranges painted with the CSS Custom Highlight API, so the page's own nodes are never changed and React keeps owning them.SettingsShellmounts the find field and the header button. The shortcut, the button and a "Find on this page" palette entry open the same store.What else changed?
components/find-field.tsxso both look the same;SessionFindBarrenders it unchanged.Release note
none
Evidence
No E2E;
apps/app/tests/settings-find.test.tsand typecheck. Before: Cmd/Ctrl+F does nothing on Advanced; after: every match is highlighted with a count such as 1/9, and Enter moves between them (screenshot in the feature doc).Design: S6, P5, C1