Repository navigation
feat(coding-agent): add explicit skill selection workflow - #132
Merged
Merged
Conversation
Replace per-skill slash commands with categorized keyboard navigation and compact atomic skill-reference tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit, keyboard-driven skill selection workflow backed by one stable, versioned skill catalog shared across interactive prompts, queued requests, SDK consumers, telemetry, exports, and evolution inputs.
Reasoning
Skills were previously exposed as individual
/skill:namecommands and materialized through multiple runtime paths without one durable identity and content-version contract. That made source scope unclear, cluttered command discovery and editor input, and allowed queued or long-lived references to drift from the content originally selected.A unified catalog gives installed and evolved skills the same provenance and snapshot semantics. Compact editor tokens keep the interaction readable while preserving exact internal references, and explicit install-scope selection prevents interactive package installs from silently choosing global state when workspace trust and storage boundaries matter.
Changes
/skillsselector for installed workspace, installed global, and evolved skills with keyboard navigation, search, multi-selection, and responsive rendering.User impact
Users now open
/skills, choose a source category, select one or more skills, add their task, and submit the exact captured versions while seeing only compact skill names in the editor. Unselected skills remain progressively disclosed. Individual/skill:namecommands are removed, and interactive package installs require an explicit global or workspace choice without silently falling back when workspace installation is unavailable.SDK consumers that construct
Skillobjects directly must migrate tocreateSkill()so the required catalog identity, provenance, content, digest, and version fields are populated.Testing
cd packages/tui && node --test test/editor.test.ts test/editor-history-keybindings.test.ts test/editor-placeholder-cursor.test.ts test/editor-text-tokens.test.ts- 195 tests passedcd packages/coding-agent && node ../../node_modules/vitest/dist/cli.js --run test/skill-selector.test.ts test/interactive-mode-skills.test.ts test/interactive-mode-status.test.ts test/suite/agent-session-prompt.test.ts- 61 tests passednpm run check- passed./test.sh- coding-agent passed 2,221 tests; the aggregate command later stopped in unchangedpackages/coding-agent-server/test/websocket-flow.test.tsbecause@earendil-works/diffex-client/websocketcould not be resolved locallybuild-check-testandbuildchecks passed for head6f0f60212a67087f317ddf0dc2663412d9be37fa/skills, verified all three source categories, opened the workspace skill list, selected a skill, and verified only its compact name appeared in the editorThis pull request is AI-generated by Diffex.