Repository navigation
fix(skills-evolution): harden candidate processing and details - #155
Merged
Pepps233 merged 12 commits intoAug 31, 2026
Merged
Conversation
Pepps233
force-pushed
the
fix/skills-evolution-ux
branch
2 times, most recently
from
August 30, 2026 15:10
fb56081 to
c03bd19
Compare
Pepps233
force-pushed
the
fix/skills-evolution-ux
branch
from
August 30, 2026 21:32
c03bd19 to
28de8bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent concurrent evolution runtimes from processing the same skill-candidate job, producing duplicate drafts, and recording a failure after another processor has already completed the work. Also keep evolved-skill detail output focused on the target harness and review material.
Reasoning
Candidate polling was advisory: every Diffex process could select the same completed evolution job, and registry compare-and-swap protected individual appends without claiming the full processing operation. Two processors could therefore share a work ID and attempt, invoke synthesis twice, race lifecycle transitions, and leave contradictory completion/failure history.
A renewable, fenced candidate-work lease makes ownership durable across processes while preserving the existing completion-dominates-retry behavior. Retry paths remain safe by treating identical downstream lifecycle records as idempotent and by binding draft identity to synthesized content.
Changes
Testing
npm run check./test.shcd packages/evolution && node ../../node_modules/vitest/dist/cli.js --run test/skill-candidate-worker.test.ts test/skill-candidate-registry.test.ts test/skill-synthesizer.test.ts test/filesystem-store.test.tscd packages/coding-agent && node ../../node_modules/vitest/dist/cli.js --run test/evolution-runtime.test.ts