Repository navigation
feat(skills): skip unavailable candidate evaluation - #158
Merged
Merged
Conversation
Pepps233
force-pushed
the
feat/skip-skill-evaluator
branch
from
August 30, 2026 02:56
70a72e6 to
1b2e496
Compare
Pepps233
force-pushed
the
feat/skip-skill-evaluator
branch
from
August 30, 2026 15:10
9e3daaf to
9cc0900
Compare
Pepps233
force-pushed
the
feat/skip-skill-evaluator
branch
from
August 30, 2026 21:32
a139c89 to
045b668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow skill evolution to complete without a configured retrieval and behavior evaluator. Deterministically validated candidates now record an explicit evaluation-skip transition, become eligible for operator-confirmed activation, and can be installed into the selected harness revision.
Reasoning
Production Diffex does not currently construct a skill evaluator. Candidate processing therefore stopped after deterministic validation, leaving generated drafts structurally valid but permanently parked and unavailable for activation.
A persisted skip transition keeps the temporary bypass explicit instead of treating structural validation as evaluation. The writer accepts an unevaluated candidate only when that exact transition is present, while retaining provenance, immutable artifact, workspace, inventory, harness-base, lease, and explicit-confirmation checks.
Changes
retrieval-and-behavior-evaluation-skippedbefore accepting an unevaluated candidate./evolvewhile keeping activation confirmation mandatory.Testing
npm run checkcd packages/evolution && node ../../node_modules/vitest/dist/cli.js --run test/skill-candidate-worker.test.ts test/skill-candidate-registry.test.ts test/skill-writer.test.tscd packages/coding-agent && node ../../node_modules/vitest/dist/cli.js --run test/evolution-runtime.test.ts test/evolution-menu.test.ts./test.shattempted: the evolution suite passed 217 tests, while the aggregate run failed in three unrelated coding-agent tests (agent-session-concurrent.test.tsand two existing harness skill-version assertions) plus an unhandled missing Anthropic API key rejection.