Repository navigation
fix(agent): reconcile and classify skill candidate retries - #161
Merged
Pepps233 merged 2 commits intoAug 31, 2026
Merged
Conversation
Pepps233
force-pushed
the
fix/skills-evolution-production
branch
from
August 30, 2026 21:32
b9452f7 to
27b2f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconcile legacy skill-candidate work and make synthesis retries follow durable error classification. Deterministic schema, artifact, and input failures now become terminal immediately, transient provider and transport failures retain bounded retries by synthesis identity across source jobs, and later qualified candidates continue through validation and evaluation.
Reasoning
Candidate synthesis previously counted retries against the source evolution job and ignored
EvolutionExecutionError.retryable. Deterministic failures were retried three times, while the same synthesis identity could receive a fresh retry budget from a later job.Legacy exhausted synthesis and completed candidate work awaiting evaluation could also remain stranded after startup. Persisting the synthesis idempotency key with failure diagnostics allows retries to follow the immutable synthesis identity, while explicit terminal reason codes distinguish non-retryable failures from exhausted transient attempts.
Changes
Testing
npm run checkcd packages/ai && node ../../node_modules/vitest/dist/cli.js --run test/retry.test.ts(18 passed)cd packages/coding-agent && node ../../node_modules/vitest/dist/cli.js --run test/evolution-runtime.test.ts(32 passed)cd packages/evolution && node ../../node_modules/vitest/dist/cli.js --run test/skill-candidate-worker.test.ts test/skill-candidate-registry.test.ts test/filesystem-store.test.ts(33 passed)./test.shattempted: all evolution tests passed, while the aggregate run failed in two existingtest/suite/agent-session-harness-version.test.tsassertions that expect skill content digests instead of package versions. The same two failures reproduce unchanged on base commita139c8972090e55002d84f9d8e0c702213cecfb6.