Repository navigation
fix(coding-agent): preserve task services through verification - #243
Merged
Pepps233 merged 3 commits intoSep 20, 2026
Conversation
Stop agent control processes before reading durable shell handoffs. Preserve environment-owned services through verification and block Harbor verification when control shutdown is unverified.
- Close launcher startup races and block verification when process ownership cannot be reconciled. - Exercise surviving services with real Linux CLI outcomes and the pinned gRPC verifier; reject releases lacking ownership support.
Make environment ownership explicit in benchmark configurations. Document shutdown evidence, source regression results, and the required corrected release pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve task services between Diffex shutdown and Harbor verification.
The adapter now requests environment-owned background processes, stops agent execution before verification, and retains services with validated ownership evidence until sandbox teardown.
Reasoning
Killing every process carrying the run marker also killed servers that the verifier needed.
Cleanup must distinguish transferred task services from active agent work and must block verification if agent shutdown cannot be established.
Changes
Testing
npm run checkpassed..venv/bin/python -m unittest discover -s tests: 142 tests passed.git diff --checkpassed.Source-image validation uses the actual CLI and a local faux provider.
It does not qualify the pinned npm release or replace a fresh live benchmark trial.