Skip to content

fix(coding-agent): preserve task services through verification - #243

Merged
Pepps233 merged 3 commits into
fix/environment-owned-background-processesfrom
fix/preserve-task-services-for-verification
Sep 20, 2026
Merged

Pepps233 merged 3 commits into
fix/environment-owned-background-processesfrom
fix/preserve-task-services-for-verification

Conversation

@Pepps233

@Pepps233 Pepps233 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Preserve task services between Diffex shutdown and Harbor verification.

The adapter now requests environment-owned background processes, stops agent execution before verification, and retains services with validated ownership evidence until sandbox teardown.

Reasoning

Killing every process carrying the run marker also killed servers that the verifier needed.

Cleanup must distinguish transferred task services from active agent work and must block verification if agent shutdown cannot be established.

Changes

  • Add a launcher stop barrier and PID/start-time checks, including protection against launcher death before CLI identity publication.
  • Validate durable ownership records, retain environment-owned services, and terminate untransferred work with bounded escalation.
  • Record agent shutdown and retained-service evidence separately; preserve failed and interrupted outcomes and block Harbor verification when shutdown is unverified.
  • Reconcile lifecycle evidence in offline qualification and trajectory metadata.
  • Add deterministic Linux regressions, source-CLI outcome smokes, an upstream gRPC verifier fixture, and lifecycle documentation.

Testing

  • npm run check passed.
  • .venv/bin/python -m unittest discover -s tests: 142 tests passed.
  • Seven Linux cleanup regressions passed as root on arm64 and as a non-root user on amd64.
  • 32 controlled source-CLI outcome cases passed across arm64 and amd64, covering success, service failure, forced CLI death, authentication failure, exhaustion, recovery, interrupted output, and timeout.
  • All seven unmodified pinned upstream gRPC verifier tests passed on each architecture, with service identity preserved through adapter cleanup.
  • All smoke containers were removed; git diff --check passed.

Source-image validation uses the actual CLI and a local faux provider.
It does not qualify the pinned npm release or replace a fresh live benchmark trial.

Stop agent control processes before reading durable shell handoffs. Preserve environment-owned services through verification and block Harbor verification when control shutdown is unverified.
- Close launcher startup races and block verification when process ownership cannot be reconciled.
- Exercise surviving services with real Linux CLI outcomes and the pinned gRPC verifier; reject releases lacking ownership support.
Make environment ownership explicit in benchmark configurations.
Document shutdown evidence, source regression results, and the required corrected release pin.
@Pepps233 Pepps233 added bug Something isn't working coding-agent labels Sep 20, 2026
@Pepps233 Pepps233 self-assigned this Sep 20, 2026
@Pepps233
Pepps233 added this pull request to stack #244 September 20, 2026 19:40
@Pepps233
Pepps233 marked this pull request as ready for review September 20, 2026 19:40
@Pepps233
Pepps233 merged commit 370a9e0 into main Sep 20, 2026
8 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working coding-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant