Repository navigation
fix(coding-agent): handle account-specific ChatGPT model defaults - #303
Merged
Merged
Conversation
Complete the default-selection fix proposed in #296 across startup, login, and session restoration while preserving available saved and custom models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Original #296
Prefer
gpt-5.6-terrawhen the active account actually lists it, and handle retired, restricted, or missing models across startup, login, and session restoration.Available saved selections remain unchanged; this does not automatically upgrade existing users or assume that every account can use Terra.
Reasoning
Changing the default ID alone misses account-specific availability and the actual SDK restoration path. Previously, a stale saved model could be restored despite being filtered out for the active account, or fall back to a different provider even while ChatGPT still had usable models. Login also did not select a model when the session had no model, and rejected catalogs that lacked the hardcoded default.
Use the available catalog as the selection boundary. Prefer the provider's configured default when listed, otherwise preserve provider catalog order. Stay with the saved provider when it has available models, and retain existing settings/global fallback when it has none. No new model metadata, dependencies, or network requests are introduced.
Changes
gpt-5.6-terra; leave direct OpenAI defaults unchanged.Testing
npm run check— passed../test.sh— passed with isolated credentials; provider E2E tests remain skipped.ccb8ef518: seven SDK regression cases fail on unmodified main; the full 12-case SDK regression suite passes with this change.