Repository navigation
feat(subagent): continue parents after subagents #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bf9e8f1
feat(coding-agent): await child batches
Pepps233 e2ac04a
feat(coding-agent): show child wait state
Pepps233 c253034
fix(coding-agent): keep SDK retries manual
Pepps233 f450485
docs(coding-agent): document child coordination
Pepps233 50bc888
fix(coding-agent): dedupe subagent retry guidance
Pepps233 0804db8
fix(coding-agent): include update_plan in subagent tool capture expec…
Pepps233 db72147
fix(coding-agent): preserve cancellation before subagent waits
Pepps233 032f09c
fix(coding-agent): consume matching subagent attempts
Pepps233 efb3bf7
fix(coding-agent): reset retries for queued prompts
Pepps233 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
abort()runs after the children spawn but before_waitForSubagentBatch()installs its controller, the parent run is aborted but this code can still freeze the batch and create a fresh, un-aborted wait. A child that never settles would then keep bothabort()and the original prompt pending. The cancellation state for the full session run should be preserved, then either initialize this wait as already cancelled or interrupt and skip the pending batch when the parent message was aborted. Aregression where abort lands immediately before post-run handling would help cover the timing window.