fix: severity overrides and colors by mimarz · Pull Request #5239 · digdir/designsystemet

mimarz · 2026-08-19T21:39:24Z

Found this bug when testing different config permutations during plugin work (and with example of how Kartverket had defined their config).

Fixes a bug in cli color generation where severity colors defined colors were overwritten by defaults.
Simplified color-scheme generation to better handle overrides.
Removed use of index lookup for default colors and juggling between working data model, moving conversion to tokens at the very end.
Fixed addSeverityColors so that severity colors are always last as this is wanted by designers in Token Studio and Figma Variables.
Folded chore(cli): add tests #5245 and chore: simplify color-scheme tokens generation #5256 into this PR as chore: simplify color-scheme tokens generation #5256 ended up changing a lot of the same code as this PR. Unfortunate side-effect for a lot of test files also included in this PR.

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

changeset-bot · 2026-08-19T21:39:28Z

🦋 Changeset detected

Latest commit: e7e873c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@digdir/designsystemet	Patch
@digdir/designsystemet-css	Patch
@digdir/designsystemet-types	Patch
@digdir/designsystemet-react	Patch
@digdir/designsystemet-web	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-08-19T21:41:51Z

Preview deployments for this pull request:

storybook - 25. Aug 2026 - 14:01

Copilot

Pull request overview

Fixes CLI color generation so custom severity colors and overrides are preserved.

Changes:

Preserves user-defined severity colors when adding defaults.
Simplifies color-scheme generation and override merging.
Adds a patch changeset.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`packages/cli/src/tokens/utils.ts`	Preserves custom severity colors.
`packages/cli/src/tokens/create/generators/primitives/color-scheme.ts`	Unifies color-scale and override generation.
`.changeset/eight-carrots-find.md`	Documents the patch.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

This reverts commit e75040a.

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

eirikbacker · 2026-08-25T15:27:55Z

+    result.set(name, userValue ?? value);
  }
-  return result;
+  return Object.fromEntries(result) as Theme['colors'];


Nice ☺️ though, returning an object re-introduces the issue - I was thinking to actually work with Map or tuples, as order is crucial in this project, but I guess that causes changes to a whole line of functions 😌

Lets cross that bridge when we get there :)

mimarz requested review from Barsnes and eirikbacker as code owners August 19, 2026 21:39

mimarz mentioned this pull request Aug 19, 2026

chore: fix color scale weakness #5238

Merged

mimarz requested a balanced review from Copilot August 20, 2026 06:16

Copilot started reviewing on behalf of mimarz August 20, 2026 06:17 View session

Copilot AI reviewed Aug 20, 2026

View reviewed changes

Comment thread .changeset/eight-carrots-find.md Outdated

mimarz force-pushed the fix-severity-colors-generation branch 2 times, most recently from fc106c5 to 1246dfc Compare August 20, 2026 08:15

mimarz force-pushed the fix-severity-colors-generation branch from 1246dfc to 86e321c Compare August 20, 2026 10:21

mimarz force-pushed the fix-severity-colors-generation branch from 86e321c to 42ef7e6 Compare August 20, 2026 11:53

eirikbacker reviewed Aug 20, 2026

View reviewed changes

Comment thread packages/cli/src/tokens/create/generators/primitives/color-scheme.ts Outdated

Barsnes reviewed Aug 21, 2026

View reviewed changes

Comment thread .changeset/eight-carrots-find.md Outdated

mimarz force-pushed the fix-severity-colors-generation branch from 42ef7e6 to 34c9e3a Compare August 24, 2026 06:28

mimarz force-pushed the fix-severity-colors-generation branch from 34c9e3a to 51f7213 Compare August 24, 2026 09:21

mimarz requested a balanced review from Copilot August 24, 2026 10:29

Copilot started reviewing on behalf of mimarz August 24, 2026 10:29 View session

Copilot AI reviewed Aug 24, 2026

View reviewed changes

Comment thread packages/cli/src/tokens/utils.ts Outdated

mimarz force-pushed the fix-severity-colors-generation branch 2 times, most recently from 6a278a7 to c06643a Compare August 24, 2026 10:54

mimarz force-pushed the fix-severity-colors-generation branch from c06643a to f0bec71 Compare August 24, 2026 11:39

mimarz mentioned this pull request Aug 25, 2026

chore: simplify color-scheme tokens generation #5256

Closed

mimarz and others added 15 commits August 25, 2026 12:47

add vitest and some auto-generated tests

ae88bbc

changeset

21eb9cb

fix sneaky verbose

8b9a615

revert node change that was for node matrix testing

542e9b7

added some more tests

3411050

chore: use for in instead of ramda in groupByColorScheme

2e8867e

changeset

ae568b3

fix: avoid ramda

89036fd

Revert "fix: avoid ramda"

e050d28

This reverts commit e75040a.

cleaning up some code

2f8b0d7

clarifying some things

6720159

remove use of ramda map

d997e59

simplify groupByScheme

c41a0e1

remove deepmergeRight

a8174ba

fix addSeverityColors

0735071

mimarz requested review from Barsnes and eirikbacker and a balanced review from Copilot August 25, 2026 10:53

Copilot started reviewing on behalf of mimarz August 25, 2026 10:54 View session

remove redundant changesets

7ce1900

Copilot AI reviewed Aug 25, 2026

View reviewed changes

Comment thread packages/cli/src/tokens/create/generators/primitives/color-scheme.test.ts Outdated

eirikbacker reviewed Aug 25, 2026

View reviewed changes

Comment thread packages/cli/src/tokens/utils.ts

mimarz and others added 2 commits August 25, 2026 13:00

Potential fix for pull request finding

3d276aa

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

use Map to ensure property order

e7e873c

eirikbacker reviewed Aug 25, 2026

View reviewed changes

eirikbacker approved these changes Aug 26, 2026

View reviewed changes

mimarz merged commit 3ce23c5 into main Aug 26, 2026
20 checks passed

mimarz deleted the fix-severity-colors-generation branch August 26, 2026 08:44

github-actions Bot mentioned this pull request Aug 26, 2026

chore: new release #5258

Open

Navigation Menu

Uh oh!

fix: severity overrides and colors - #5239

fix: severity overrides and colors#5239
mimarz merged 24 commits into
chore-fix-color-scale-weaknessfrom
fix-severity-colors-generation

mimarz commented Aug 19, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

eirikbacker Aug 25, 2026

Uh oh!

mimarz Aug 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mimarz commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

eirikbacker Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

mimarz Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mimarz commented Aug 19, 2026 •

edited

Loading

changeset-bot Bot commented Aug 19, 2026 •

edited

Loading

github-actions Bot commented Aug 19, 2026 •

edited

Loading

mimarz Aug 26, 2026 •

edited

Loading