Repository navigation
Fix project building with clang 23.1.4 - #882
Merged
Merged
Conversation
Collaborator
|
Thanks looks good. |
Keep main's getrandom 0.4.3 / windows-core 0.62.2 / pageant 0.2.3 pins from dirge-code#868/dirge-code#879; only bindgen's own subtree moves.
bindgen 0.73 resolves syn >=2,<4 to syn 3, whose parse_quote output only prettyplease 0.3 can unparse.
Collaborator
|
Thanks for the diagnosis — confirming the bindgen 0.70 opaque-struct bug against clang 23 and moving to 0.73 is the right fix. I pushed a few adjustments on top (same branch):
Verified locally: full build (default, plugin, sandbox-microvm), fmt, clippy, 5972 bin + 498 lib tests, cargo audit + osv-scanner clean. CI green including windows-default, sandbox-microvm and Nix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. In my Arch Linux setup with:
building of
dirgewas failed with a lot of errors like this:After some testing I found that
bindgenv0.70.0 works incorrectly (at least withclang 23.1.4):bindgenv0.73.2 works propertly:So this PR just update
bindgenversion and little fix for eliminating message about deprecated constant usage. Changes in Cargo.lock generated by commandcargo update -p bindgen -p prettyplease.