Repository navigation
Keep Http::VERSION in step with the release tags - #32
Merged
Merged
Conversation
Http::VERSION still read v10.9.4 after v10.9.5 through v10.9.8 were released. It now reads v10.9.8, and a Version workflow fails when it falls behind the latest release or differs from a release being published. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sm73Ao3BqrrSecK2rcD6Ru
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Before:
Http::VERSIONreadv10.9.4while v10.9.5 through v10.9.8 were released. DiscordPHP logs it at startup, so reports quoted the wrong Http version.After: it reads
v10.9.8. A new Version workflow fails on a push or pull request whenVERSIONis older than the latest release tag, and fails on a published release whenVERSIONdiffers from that release's tag.How:
scripts/check-version.phpreads the constant fromsrc/Discord/Http.phpand compares it with the newestvX.Y.Ztag, or, given a tag, requires an exact match..github/workflows/version.ymlruns it with a full-history checkout. Checked locally: on master it fails with "older than the latest release, v10.9.8", and after the bump it passes. It is the same check as the DiscordPHP companion PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01Sm73Ao3BqrrSecK2rcD6Ru
Generated by Claude Code