Repository navigation
UI: Let popups center on their trigger, and open the account's menu centered - #451
Merged
Merged
Conversation
…entered - DitoTrigger's placement can center popups, e.g. 'bottom-center', which keepInView shifts back into the window, exposing the shift as --dito-popup-shift - DitoMenuButton's floating tip keeps pointing at the middle of the button - The account's menu opens centered below it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #449, whose merge didn't include this: with the toggle's room now always next to the account, its menu can open centered below it.
DitoTrigger'splacementcan center popups, e.g.'bottom-center'. Centered popups can't flip their alignment, sokeepInViewshifts them back into the window, and exposes the shift as--dito-popup-shiftDitoMenuButton's floating tip uses it to keep pointing at the middle of the buttonDitoAccountuses'bottom-center'Checked in the e2e app at 1600 and 900px: the menu and its tip are centered on the button. Unit tests cover centering and the shift at both window edges.