Skip to content

Missing Makefile targets: test-coverage, dev-setup, lambda-package declared but undefined #10

Closed

Description

@ngoyal16

Problem

The Makefile declares test-coverage and dev-setup in the .PHONY target list (line 1) but does not define them:

.PHONY: build clean test test-coverage dev-setup fmt lint lambda-package docker-build docker-build-multiarch

build:
	@go build -o bin/aws-das-processor ./...

test:
	@go test -v ./...

fmt:
	@go fmt ./...

lint:
	@golangci-lint run

clean:
	@rm -rf bin/

docker-build:
	@docker build -t aws-das-processor:latest .

docker-build-multiarch:
	@docker buildx build --platform linux/amd64,linux/arm64 -t aws-das-processor:latest .

Missing targets:

  • test-coverage — no go test -coverprofile target
  • dev-setup — no setup target for new contributors
  • lambda-package — no target to build and package the Lambda zip

Running make test-coverage or make dev-setup will silently succeed (because they are .PHONY with no recipe), giving false confidence.

Proposed Solution

test-coverage:
	@go test -coverprofile=bin/coverage.out ./...
	@go tool cover -html=bin/coverage.out -o bin/coverage.html || true
	@echo "Coverage report: bin/coverage.html"

dev-setup:
	@go mod download
	@go install honnef.co/go/tools/cmd/staticcheck@latest || true
	@go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest || true
	@echo "Development environment ready."

lambda-package:
	@GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o bin/bootstrap main.go filter.go
	@cd bin && zip -j aws-das-processor.zip bootstrap
	@echo "Lambda package: bin/aws-das-processor.zip"

Acceptance Criteria

  • make test-coverage generates a coverage report
  • make dev-setup installs dev dependencies
  • make lambda-package builds a deployable Lambda zip
  • All targets listed in .PHONY have defined recipes

Activity

  1. maham146 commented on Sep 28, 2026

    @maham146
    Contributor

    I'd like to work on this

  2. ngoyal16 commented on Sep 28, 2026

    @ngoyal16
    ContributorAuthor

    @maham146 thanks for your interset please share the PR

  3. maham146 commented on Sep 28, 2026

    @maham146
    Contributor

    PR is up: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ci-cdCI/CD pipeline and automationenhancementNew feature or requestgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions