fix: implement SQS partial batch failure handling - #23
Merged
Merged
Conversation
- Return events.SQSEventResponse with BatchItemFailures to avoid reprocessing succeeded records - Extract processMessage and processSQSEvent for granular per-message failure tracking - Configure FunctionResponseTypes: ['ReportBatchItemFailures'] in CloudFormation EventSourceMapping - Introduce S3Client and KMSClient interfaces for mockability - Fix conflicting dict,plain parquet tags on DatabaseActivityEvent - Add unit tests covering partial batch failure, all success, all fail, and error cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Summary of Changes
handlersignature to returnevents.SQSEventResponsecontainingBatchItemFailures.processMessageandprocessSQSEvent. If an individual record fails, itsMessageIdis appended toBatchItemFailureswhile allowing other records in the SQS batch to proceed without reprocessing previously written records.EventSourceMappingin deploy/cloudformation/lambda.yaml withFunctionResponseTypes: ['ReportBatchItemFailures']so AWS Lambda properly respects partial failure responses.S3ClientandKMSClientinterfaces to decouple AWS SDK calls and enable clean unit test mocking.dict,plainencoding tags onDatabaseActivityEventfields which were causing a runtime panic inparquet-go.BatchItemFailuresBatchItemFailuresBatchItemFailures