feat(deploy): add DLQ, log retention, and existing destination bucket to CloudFormation - #25
Merged
Merged
Conversation
… to CloudFormation (#18) - Add ProcessorDeadLetterQueue SQS resource and RedrivePolicy to ProcessorQueue with configurable SqsMaxReceiveCount - Add explicit AWS::Logs::LogGroup resource with configurable LogRetentionDays - Parameterize LambdaMemorySize (default 512MB) - Remove internal DestinationBucket creation and replace with DasDestinationBucketName parameter for existing data lake bucket integration - Update IAM execution role and DAS_OUTPUT_BUCKET to use DasDestinationBucketName - Add stack outputs for ProcessorDLQArn and ProcessorDLQUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Summary of Changes
ProcessorDeadLetterQueue(AWS::SQS::Queue) with server-side encryption and 14-day retention. Attached aRedrivePolicytoProcessorQueuewith configurableSqsMaxReceiveCount(default:5).ProcessorLogGroup(AWS::Logs::LogGroup) with configurableLogRetentionDays(default:30) to eliminate perpetual CloudWatch storage accumulation.DestinationBucketin favor of an input parameterDasDestinationBucketNameto write into existing pre-provisioned data lake buckets.LambdaExecutionRoleto grants3:PutObjectpermissions specifically toarn:aws:s3:::${DasDestinationBucketName}/*.LambdaMemorySize(default:512, allowed values:256-3072).ProcessorDLQArnandProcessorDLQUrloutputs.