Add support for more platforms

[xtqqczze]

Closes #60

Verified locally with:

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std \
  --workspace --all-targets --all-features \
  --target powerpc64-ibm-aix \
  --target aarch64-apple-ios \
  --target aarch64-apple-ios-macabi \
  --target aarch64-apple-ios-sim \
  --target aarch64-apple-tvos \
  --target aarch64-apple-tvos-sim \
  --target aarch64-apple-visionos \
  --target aarch64-apple-visionos-sim \
  --target aarch64-apple-watchos \
  --target aarch64-apple-watchos-sim \
  --target x86_64-apple-ios \
  --target x86_64-apple-ios-macabi

[xtqqczze]

@djc Hopefully this can be backported, I'd like to avoid taking a dependency on windows-link v0.100.0.

[djc]

@djc Hopefully this can be backported, I'd like to avoid taking a dependency on windows-link v0.100.0.

Why?

[xtqqczze]

windows-link v0.100.0 was only released 14 days ago, and most crates haven't adopted it yet. Using it here would therefore introduce a duplicate dependency for uutils.

[djc]

Okay, I think we can get out a 0.4.3 release with this. Suggest you add commits (a) reverting the offending commits before your change, (b) bumping the version to 0.4.3, (c) adding back the reverted changes all on this branch. After merging this, I will tag and publish the version bump.

[xtqqczze]

@djc Why isn't CI running?

[djc]

No clue -- probably a GitHub fluke?

[xtqqczze]

I don't think it's a fluke, it consistently isn't running, so I suspect it's an issue with the repo (maybe permissions?).

[djc]

Can you try another push?

[xtqqczze]

I checked the Actions dashboard, no workflow runs were even created.

[djc]

Ugh, you're right. Fixing in

• ci: trigger workflow for pull requests #62

[djc]

Alright, please rebase on current main?

[xtqqczze]

@djc I'm working on some CI improvements.

Just to confirm, is it desirable to have CI for every Apple target listed in the Tier 2 with Host Tools documentation?

[djc]

Just to confirm, is it desirable to have CI for every Apple target listed in the Tier 2 with Host Tools documentation?

I inherited the current matrix and have not spent much time on it. I'm not eager to expand it more for theoretical use cases but if you're building for a particular platform I'm happy to have it added. I expect it could be a fair bit simpler by, for example, collapsing all Apple targets into a single one.

[xtqqczze]

sethostname and gethostname have the same definition in libc across all Apple targets. Since there’s no need to test each target purely for completeness, I’ve removed the additional targets like aarch64-apple-visionos-sim from CI.

[djc]

The "refactor MSRV job" reads like it's doing a whole bunch of stuff at the same time. Either split that out or clarify in the commit message what goals/concerns it's trying to address.

[xtqqczze]

At this point, it may be worth splitting the PR to separate the CI changes from the additional target support?

[djc]

At this point, it may be worth splitting the PR to separate the CI changes from the additional target support?

Yes, please!