Repository navigation
Backup sync tests, bcrypt, and lifespan scheduler - #1
Merged
Merged
Conversation
The BACKUP_SYNC_CMD path had no tests: env handed to the command, error cleared on success, failure recorded as type + exit code only (never the command line, which can carry a credential into every nightly snapshot), local backup still counted good, and the failure surfaced in Settings and Operations.
passlib is unmaintained, pinned bcrypt to <4.1 and imports the crypt module Python 3.13 removes. auth_core now calls bcrypt (5.0) itself and truncates to 72 bytes as passlib did, so existing password and backup-code hashes keep verifying (pinned with real passlib-generated fixtures) and a long password never reaches bcrypt 5's ValueError. The test client moves to httpx2, which Starlette now expects; the suite runs warning-free.
@app.on_event is deprecated and slated for removal; when it goes, redeploys would kill a running backup or mail flush mid-write. Same behavior, now via FastAPI's lifespan, with a test that shutdown waits for running jobs.
…cy check The page's per-request nonce is random base64 and contained "88" (the hidden rate) about once per 200 renders, failing MR pipeline #369.
# Conflicts: # .gitlab-ci.yml
dlommm
force-pushed
the
chore/backup-sync-tests-and-deps
branch
from
October 23, 2026 03:29
c7cb7b4 to
286fc9e
Compare
# Conflicts: # requirements-dev.lock # requirements.lock # requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from GitLab MR !1.