Skip to content

Backup sync tests, bcrypt, and lifespan scheduler - #1

Merged
dlommm merged 7 commits into
mainfrom
chore/backup-sync-tests-and-deps
Oct 23, 2026
Merged

dlommm merged 7 commits into
mainfrom
chore/backup-sync-tests-and-deps

Conversation

@dlommm

@dlommm dlommm commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Migrated from GitLab MR !1.

  • test(backup): pin the off-box sync contract
  • fix(deps): hash with bcrypt directly; drop unmaintained passlib
  • fix(app): stop the scheduler from a lifespan handler
  • test(permissions): ignore the random CSP nonce in the tech rate-privacy check

The BACKUP_SYNC_CMD path had no tests: env handed to the command, error
cleared on success, failure recorded as type + exit code only (never the
command line, which can carry a credential into every nightly snapshot),
local backup still counted good, and the failure surfaced in Settings and
Operations.
passlib is unmaintained, pinned bcrypt to <4.1 and imports the crypt module
Python 3.13 removes. auth_core now calls bcrypt (5.0) itself and truncates to
72 bytes as passlib did, so existing password and backup-code hashes keep
verifying (pinned with real passlib-generated fixtures) and a long password
never reaches bcrypt 5's ValueError. The test client moves to httpx2, which
Starlette now expects; the suite runs warning-free.
@app.on_event is deprecated and slated for removal; when it goes, redeploys
would kill a running backup or mail flush mid-write. Same behavior, now via
FastAPI's lifespan, with a test that shutdown waits for running jobs.
…cy check

The page's per-request nonce is random base64 and contained "88" (the
hidden rate) about once per 200 renders, failing MR pipeline #369.
# Conflicts:
#	requirements-dev.lock
#	requirements.lock
#	requirements.txt
@dlommm
dlommm merged commit ec6733c into main Oct 23, 2026
7 checks passed
@dlommm
dlommm deleted the chore/backup-sync-tests-and-deps branch October 23, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant