fix(video): Prevent hang in SkipFramesImpl by adding pop retry limit - #342
Open
xx205 wants to merge 1 commit into
Open
fix(video): Prevent hang in SkipFramesImpl by adding pop retry limit#342xx205 wants to merge 1 commit into
xx205 wants to merge 1 commit into
Conversation
SkipFramesImpl could hang when `decoder_->Pop` returned `false` after receiving an empty NDArray (EAGAIN signal), as the skip counter didn't decrement. If the decoder then stalled, `frame_count_` remained zero, causing subsequent `Pop` calls to fail rapidly at the entry check, leading to hangs or malloc deadlocks. This commit adds a retry limit to the `SkipFramesImpl` loop to break this rapid failure cycle after consecutive `Pop` failures. This improves robustness when skipping frames in problematic videos after seeking.
Author
yudian0504
added a commit
to yudian0504/decord2
that referenced
this pull request
Nov 23, 2025
chr431
pushed a commit
to chr431/decord
that referenced
this pull request
Aug 15, 2026
从 dmlc/decord open issues/PR 筛选并本地验证后移植： - NDArray.pts int->int64_t（dmlc#269/dmlc#341）；SkipFramesImpl 用 Drained() 判真 EOF，避免容器虚标帧数时死循环并采样 EOF 幽灵帧（dmlc#373/dmlc#342） - CheckKeyFrame EOF 出口 + GetFrameCount avg_frame_rate.den==0 防除零（dmlc#230） - FFmpeg 7 buffersink pix_fmts 类型变化守卫（libavfilter>=10，PR dmlc#368），新增 Windows FFmpeg 7.1 CI job - 帧索引缓存版本混入 LIBAVFORMAT_VERSION_INT，防止跨 FFmpeg 构建误用旧缓存（本地实测 7.1/8.1 时间戳不一致） - ctypes 默认 RTLD_LOCAL + DECORD_RTLD_GLOBAL 逃生开关，PATH 缺失兜底（dmlc#361/dmlc#362/dmlc#357） - _init_internal_api 显式 import _api_internal（PR dmlc#364）；AVReader sample_rate 默认值与文档对齐为 -1（PR dmlc#237） - VideoReader.close()/上下文管理器（dmlc#222）；GPU VP8 映射（dmlc#217）；worker 停止后的 Push 可读报错（dmlc#321） - 新增回归：large_pts.mp4 大 PTS get_batch/seek、close/context manager、PATH 缺失、RTLD_GLOBAL 开关、AVReader 默认值 - 本地验证：Windows GPU FFmpeg 8.1 61 tests、CPU FFmpeg 8.1 60 tests、CPU FFmpeg 7.1 60 tests 全绿
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipFramesImpl could hang when
decoder_->Popreturnedfalseafter receiving an empty NDArray (EAGAIN signal), as the skip counter didn't decrement. If the decoder then stalled,frame_count_remained zero, causing subsequentPopcalls to fail rapidly at the entry check, leading to hangs or malloc deadlocks. This commit adds a retry limit to theSkipFramesImplloop to break this rapid failure cycle after consecutivePopfailures. This improves robustness when skipping frames in problematic videos after seeking.