Repository navigation
fix(nodeswap): Windows finder matches a node started through a junction - #850
Merged
Merged
Conversation
CIM reports the path a process was started through. A llama-swap launched from its junctioned live directory never compared equal to the generation path the swap names, so the post-restart check and the rollback's check both failed against a running node. Match by file identity (os.SameFile) after fetching candidates by name; exact spelling still matches and unreadable rows are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…de lint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
dmmdea
added a commit
that referenced
this pull request
Nov 11, 2026
- **Fixed:** a Windows swap now sees a node started through a junction (#850). A component's live directory can be a junction into its generation directory. The process finder compared the path CIM reports with the generation path by spelling, so a llama-swap swap restarted the daemon and then reported "no process appeared", and the rollback check failed the same way. Paths are now matched by the file they name. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Deletes: changes/unreleased/fix-windows-finder-follows-junctions.md Co-authored-by: dmmdea <dmmdea@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed - a Windows swap sees a node started through a junction
<home>/llama-swap-><home>/llama-swap-versions/<id>). The process finder compared the path CIM reports, which is the path the process was started through (the junction), with the generation path the swap names, by spelling. The two never matched. Measured on a Windows node: the swap restarted llama-swap, and both the post-restart check and the rollback's check reported "no process appeared" against a running node.os.SameFile). It still accepts an exact spelling. A junction or symlink on either side, or a short 8.3 name, now matches. A process whose path the OS will not give is still returned as unreadable, as before. The Linux finder already resolved links.internal/nodeswap/deps_windows.go(findProcessesByExeWindows,sameExecutable).🤖 Generated with Claude Code