Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ func isArchive(header []byte) bool {
{0x42, 0x5A, 0x68}, // bzip2
{0x1F, 0x8B, 0x08}, // gzip
{0xFD, 0x37, 0x7A, 0x58, 0x5A, 0x00}, // xz
{0x28, 0xB5, 0x2F, 0xFD}, // zstd
} {
if len(header) < len(m) {
continue
Expand Down
62 changes: 62 additions & 0 deletions build/utils_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package build

import (
"archive/tar"
"bytes"
"context"
"strings"
"testing"
Expand Down Expand Up @@ -257,3 +259,63 @@ func TestParseResourceLimits(t *testing.T) {
require.Error(t, err)
})
}

func TestIsArchive(t *testing.T) {
tarHeader := func() []byte {
var buf bytes.Buffer
tw := tar.NewWriter(&buf)
require.NoError(t, tw.WriteHeader(&tar.Header{Name: "Dockerfile", Mode: 0o644, Size: 13}))
_, err := tw.Write([]byte("FROM scratch\n"))
require.NoError(t, err)
require.NoError(t, tw.Close())
return buf.Bytes()
}

tests := []struct {
doc string
header []byte
expected bool
}{
{
doc: "plain tar",
header: tarHeader(),
expected: true,
},
{
doc: "gzip",
header: []byte{0x1F, 0x8B, 0x08, 0x00},
expected: true,
},
{
doc: "bzip2",
header: []byte{0x42, 0x5A, 0x68, 0x31},
expected: true,
},
{
doc: "xz",
header: []byte{0xFD, 0x37, 0x7A, 0x58, 0x5A, 0x00},
expected: true,
},
{
doc: "zstd",
header: []byte{0x28, 0xB5, 0x2F, 0xFD, 0x00},
expected: true,
},
{
doc: "dockerfile",
header: []byte("FROM scratch\n"),
expected: false,
},
{
doc: "truncated zstd magic",
header: []byte{0x28, 0xB5},
expected: false,
},
}

for _, tt := range tests {
t.Run(tt.doc, func(t *testing.T) {
require.Equal(t, tt.expected, isArchive(tt.header))
})
}
}