Conversation
Return daemon probe errors instead of treating them as unsupported features. Cache only successful results per docker context so failed or canceled probes can be retried. Probe the builder endpoint for the docker driver and the load destination for other drivers. Skip daemon detection for tarball exports, and cover retries, cancellation, concurrent lookups, and exporter probe selection. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Return feature detection errors through the driver interface and cache only successful Docker worker probes so transient failures can be retried. Resolve features before constructing build options and reuse that result for capability checks. This prevents failed probes from silently disabling default provenance before a later successful probe allows the build to proceed. Report detection failures in debug inspection and cover retries, caching, and provenance preservation. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #4082
Address the Docker driver
ListWorkersfeature cache. Return detection errors through the driver interface and cache only successful results, so transient failures can be retried without being mistaken for unsupported capabilities.This was deferred from #4082 because safely retrying failed probes requires updating the driver interface and its callers. Without error propagation, an early failure could disable default provenance while a later successful probe allows the build to proceed without it. Resolve features before constructing build options and reuse the successful result for capability checks, ensuring detection failures stop the build instead of silently changing its output.