Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3132
supersedes and closes #3756
history logsnow prints the stored build error after replaying progress output. This makes failures that are not directly associated with a build vertex, such as cache-key computation errors, visible without requiring a separatehistory inspectcommand. Error sources and failed-vertex logs use the same formatting ashistory inspect, while raw JSON output remains valid NDJSON.The change also ensures status streams and progress printers are cleaned up on every exit path.
Can be reproduced with a cache-key failure caused by a missing build context file.
Before this change, the output ends without the stored error details:
After this change,
history logsprints the stored error and source location at the end: