Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bake/bake.go
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ func (c Config) newOverrides(v []string) (map[string]map[string]Override, error)
// IMPORTANT: if you add more fields here, do not forget to update
// docs/reference/buildx_bake.md (--set) and https://docs.docker.com/build/bake/overrides/
switch keys[1] {
case "output", "cache-to", "cache-from", "tags", "platform", "secrets", "ssh", "attest", "entitlements", "network", "annotations", "policy":
case "output", "cache-to", "cache-from", "tags", "platform", "secrets", "ssh", "attest", "entitlements", "annotations", "policy", "ulimits", "no-cache-filter":
if len(parts) == 2 {
override.Append = appendTo
override.ArrValue = append(override.ArrValue, parts[1])
Expand Down
18 changes: 18 additions & 0 deletions bake/bake_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,12 @@ target "webapp" {
require.Equal(t, []string{"webapp"}, g["default"].Targets)
})

t.Run("NoCacheFilterOverride", func(t *testing.T) {
m, _, err := ReadTargets(ctx, []File{fp}, []string{"webapp"}, []string{"webapp.no-cache-filter=stage"}, nil, nil, &EntitlementConf{})
require.NoError(t, err)
require.Equal(t, []string{"stage"}, m["webapp"].NoCacheFilter)
})

t.Run("PlatformOverride", func(t *testing.T) {
m, _, err := ReadTargets(ctx, []File{fp}, []string{"webapp"}, []string{"webapp.platform=linux/arm64"}, nil, nil, &EntitlementConf{})
require.NoError(t, err)
Expand Down Expand Up @@ -286,6 +292,18 @@ target "webapp" {
require.Equal(t, "256m", *m["webapp"].ShmSize)
})

t.Run("NetworkOverride", func(t *testing.T) {
m, _, err := ReadTargets(ctx, []File{fp}, []string{"webapp"}, []string{"webapp.network=host"}, nil, nil, &EntitlementConf{})
require.NoError(t, err)
require.Equal(t, "host", *m["webapp"].NetworkMode)
})

t.Run("UlimitsOverride", func(t *testing.T) {
m, _, err := ReadTargets(ctx, []File{fp}, []string{"webapp"}, []string{"webapp.ulimits=nofile=2048:2048"}, nil, nil, &EntitlementConf{})
require.NoError(t, err)
require.Equal(t, []string{"nofile=2048:2048"}, m["webapp"].Ulimits)
})

t.Run("ResourceLimitsOverride", func(t *testing.T) {
m, _, err := ReadTargets(ctx, []File{fp}, []string{"webapp"}, []string{
"webapp.resources.memory=512m",
Expand Down
6 changes: 6 additions & 0 deletions docs/reference/buildx_bake.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,16 +463,20 @@ You can override the following fields:
* `load`
* `no-cache`
* `no-cache-filter`
* `network`
* `output`
* `platform`
* `policy`
* `pull`
* `push`
* `resources`
* `secret.<id>`
* `secrets`
* `shm-size`
* `ssh`
* `tags`
* `target`
* `ulimits`

You can append using `+=` operator for the following fields:

Expand All @@ -484,9 +488,11 @@ You can append using `+=` operator for the following fields:
* `no-cache-filter`
* `output`
* `platform`
* `policy`
* `secrets`
* `ssh`
* `tags`
* `ulimits`

> [!NOTE]
> ¹ These fields already append by default.
Expand Down
Loading