Some RPSystem TU's

[ThePlayerRolo]

Currently RPSysQueue is linked with RP_80186E40 being merged with RPSysLoadScene.

I tried to define RP_80186E40 as a seperate tu but since the lbl for it is never used anywhere it gets optimized out, leading to linking errors.

I assume its apart of RPSysLoadScene due to its position in text, however if you think otherwise I can undo it

[decomp-dev]

Report for RSPE01_01 (4c08445 - c91328c)

📈 Matched code: 34.17% (+0.03%, +1156 bytes)
📈 Linked code: 28.10% (+0.01%, +188 bytes)
📈 Matched data: 37.56% (+0.00%, +44 bytes)
📈 Linked data: 54.07% (+0.00%, +24 bytes)

✅ 14 new matches

Unit	Item	Bytes	Before	After
main/Pack/RPSystem/RPSysCommonObject	RPSysCommonObject::RPSysCommonObject()	+296	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	RPSysCommonObject::postUpdate()	+136	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	RPSysCommonObject::UserDraw()	+124	0.00%	100.00%
main/Pack/RPSystem/RPSysQueuedScene	RPSysQueuedScene::CreateInstance(EGG::Heap*)	+112	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	RPSysCommonObject::preUpdate()	+100	0.00%	100.00%
main/Pack/RPSystem/RP_80186E40	__sinit_\RP_80186E40_cpp	+88	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	RPSysCommonObject::init()	+68	0.00%	100.00%
main/Pack/RPSystem/RPSysQueuedScene	RPSysQueuedScene::~RPSysQueuedScene()	+64	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	RPSysCommonObject::~RPSysCommonObject()	+64	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	RPGrpScreen::~RPGrpScreen()	+64	0.00%	100.00%
main/Pack/RPSystem/RPSysCommonObject	.data	+40	0.00%	100.00%
main/Pack/RPSystem/RP_80186E40	__arraydtor$25785	+28	0.00%	100.00%
main/Pack/RPSystem/RPSysQueuedScene	RPSysQueuedScene::reset()	+12	0.00%	100.00%
main/Pack/RPSystem/RP_80186E40	.ctors	+4	0.00%	100.00%

📈 4 improvements in unmatched items

Unit	Item	Bytes	Before	After
main/Pack/RPSystem/RP_80186E40	.bss	+60	0.00%	93.75%
main/Pack/RPSystem/RPSysQueuedScene	.data	+13	0.00%	85.71%
main/Pack/RPSystem/RPSysQueuedScene	.sbss	+5	0.00%	66.67%
main/Pack/RPSystem/RPSysCommonObject	.sdata2	+4	0.00%	50.00%

[kiwi515]

hi, thank you- i appreciate the pr! im pretty confident the static initializer is from some mystery tu because it only exists in revision 1 of the game, despite RPSysLoadScene being basically equivalent between the two revisions. also, there arent any symbols in wii fit u that suggest there could be extra data

[ThePlayerRolo]

hi, thank you- i appreciate the pr! im pretty confident the static initializer is from some mystery tu because it only exists in revision 1 of the game, despite RPSysLoadScene being basically equivalent between the two revisions. also, there arent any symbols in wii fit u that suggest there could be extra data

ah I see
I'll make it a seperate tu again

I'm also working on RPSysCommonObject

[ThePlayerRolo]

ready for review again

do note that i tried to keep symbol names aligned with the ghidra repo and wii fit u symbols ( I didn't know wii fit u had symbols before lol)