Repository navigation
Introduce a signal bus contract - #390
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Introduce a signal bus contract so Doppar services can depend on an abstraction rather than the concrete
SignalBusimplementation. This follows the same pattern as the URL generator, string, storage, mail, hashing and encryption contracts.Changes
Phaseolies\Signals\Contracts\SignalBusInterfacecovering the eight publicSignalBusmethods:on,forget,hasListeners,emit,emitNow,emitOnSettle,settleandreportFailuresUsing.SignalBusto implement the contract.FacadeLauncherand keptsignalas an alias of it.Database::stageSignal()to acceptSignalBusInterfaceinstead of the concreteSignalBus.signal()helper andSignalfacade docblocks to reference the contract.'signal'andsignal()resolving to the same singleton.Backward Compatibility
app('signal'), thesignal()helper and theSignalfacade keep working. The contract and thesignalkey resolve to the same singleton instance, and no method signatures changed.Database::stageSignal()now accepts the interface.SignalBusimplements it, so every existing caller still type-checks.Notes
settle()is part of the contract becauseDatabasecalls it when a transaction settles. It is meant forDatabase, not for application code.Checklist