Repository navigation
Skip updating/updated hooks for bound fields that did not change - #11
Merged
Merged
Conversation
abdulmajidcse
approved these changes
Oct 30, 2026
abdulmajidcse
left a comment
Member
There was a problem hiding this comment.
Looks good. Tested locally: the pagination hook fix, keyed reorder (including focus and selection), poll queuing and the post_max_size message all work as described, and CI is green.
xentixar
approved these changes
Oct 31, 2026
xentixar
left a comment
Member
There was a problem hiding this comment.
Looks good! Thank you, @techmahedy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound fields ride along with every action request, and the browser sends them as strings. A "5" for an int $perPage that already holds 5 was applied through syncProperty(), so updating() and updated() ran on every action even though nothing changed.
A hook such as updated('perPage') that resets the page to 1 therefore fired on every Next/Prev click, and pagination could never leave page 1.
type coercion.
only for fields that actually changed.
Tests:
Reorder
Polling
Uploads
Navigation