Repository navigation
Fix bind and validation timing, add ripple:submit, and show a progress bar on soft navigation - #5
Merged
Merged
Conversation
- Updated the debounce configuration in `ripple.php` and `configuration.md` to clarify its application to `ripple:bind.debounce`. - Enhanced the `bind.js` logic to ensure proper handling of debounce modifiers. - Introduced a new `deferredModels` function in `dom.js` to manage plain ripple:bind values that differ from signed state. - Updated the `syncProperty` method in `Component.php` to allow optional validation reset. - Added tests to verify the application of deferred models during property updates.
- Introduced `ripple:submit` directive to streamline form submission actions, allowing buttons to specify their own methods. - Updated `submitAction` function in `dom.js` to prioritize button-specific actions over form-level submissions. - Modified event listener in `listeners.js` to accommodate the new submission logic and ensure proper confirmation handling. - Revised documentation in `README.md` and `directives.md` to reflect changes in directive usage and form handling.
- Added configuration options for a top progress bar during soft navigations in `ripple.php`, allowing customization of visibility and color. - Introduced `startProgress` and `finishProgress` functions in `progress.js` to manage the display of the progress bar. - Updated `softNavigate` function in `navigate.js` to trigger progress bar visibility during navigation. - Enhanced documentation to include details about the new progress bar feature in `configuration.md` and `navigation.md`. - Added tests to verify the correct rendering of progress bar settings in `ComponentManagerTest.php`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain
ripple:bindnow waits for the next request instead of posting on blur..debounceis its own modifier (default pause still comes fromperformance.debounce_default), and values that only exist on the client get sent along with a call or a property update.Property updates no longer wipe the error bag for that field before rechecking it. If another rule reads the field (
confirmed,same_as,different), that rule is checked again too. Flushing models before an action still clears errors once the values are applied.Forms can use
ripple:submit="save". A submit button with its ownripple:submitwins over the form.Soft navigations (
ripple:navigate, soft redirects, back/forward) show a thin bar on<html>when the request takes more than about 150ms. Turn it off withnavigate.show_progress_bar, or change the color withnavigate.progress_bar_color/--ripple-progress.