Use AsyncTask thread-safe debug logging in LinkNativeRuntime#12111
Merged
jonathanpeppers merged 2 commits intoJul 15, 2026
Conversation
4 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix use of thread-safe LogDebugMessage in LinkNativeRuntime
Use AsyncTask thread-safe debug logging in LinkNativeRuntime
Jul 15, 2026
simonrozsival
approved these changes
Jul 15, 2026
jonathanpeppers
approved these changes
Jul 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates LinkNativeRuntime to use AsyncTask’s thread-safe debug logging helper when running LinkRuntime work concurrently, avoiding direct use of the TaskLoggingHelper debug log API from a background task context.
Changes:
- Switched
Log.LogDebugMessage (...)toLogDebugMessage (...)inLinkNativeRuntime.LinkRuntime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkNativeRuntimeexecutesLinkRuntimeviaAsyncTask.WhenAll(...), so using the obsoleteLogproperty from that background path is unsafe. This change switches the debug log call to theAsyncTaskthread-safe helper without altering behavior or message content.Change scope
src/Xamarin.Android.Build.Tasks/Tasks/LinkNativeRuntime.cs:Log.LogDebugMessage(...)→LogDebugMessage(...)Why this matters
AsyncTaskusage with repository guidance for background-thread-safe logging.Logproperty in async task execution.Code change