Skip to content

Use universal DBI for cDAC debugging - #5942

Merged
hoyosjs merged 1 commit into
mainfrom
juhoyosa/remove-pal-dbi
Jul 28, 2026
Merged

Use universal DBI for cDAC debugging#5942
hoyosjs merged 1 commit into
mainfrom
juhoyosa/remove-pal-dbi

Conversation

@hoyosjs

@hoyosjs hoyosjs commented Jul 28, 2026

Copy link
Copy Markdown
Member

The bundled cDAC path needs a DBI that owns its PAL.

  • Load mscordbi_universal for cDAC debugging.
  • Package it with dbgshim when cDAC packaging is enabled.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4c34245d-758e-44f8-a284-9e2fb9a62d3d
Copilot AI review requested due to automatic review settings July 28, 2026 11:42
@hoyosjs
hoyosjs requested a review from a team as a code owner July 28, 2026 11:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dbgshim’s cDAC debugging path to load a “universal” DBI (mscordbi_universal) alongside the bundled cDAC (mscordaccore_universal), and ensures the universal DBI is included in the DbgShim native NuGet package when cDAC packaging is enabled.

Changes:

  • Package mscordbi_universal into the Microsoft.Diagnostics.DbgShim runtime-native assets when PackageWithCDac is true.
  • Introduce UNIVERSAL_DBI_MODULE_NAME_W and switch the bundled DBI resolution for the cDAC path to mscordbi_universal.
  • Update header commentary to reflect bundling expectations (with a suggested clarification).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/dbgshim/pkg/Microsoft.Diagnostics.DbgShim.props Packs mscordbi_universal next to dbgshim and the cDAC in runtime-specific native assets when PackageWithCDac is enabled.
src/dbgshim/debugshim.h Adds the universal DBI module name constant and updates the bundling comment (with suggested clarification).
src/dbgshim/debugshim.cpp Changes the bundled DBI resolution for the cDAC debugging path to load mscordbi_universal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/dbgshim/pkg/Microsoft.Diagnostics.DbgShim.props
Comment thread src/dbgshim/debugshim.h
@hoyosjs
hoyosjs enabled auto-merge (squash) July 28, 2026 19:38
@hoyosjs
hoyosjs merged commit d33e046 into main Jul 28, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants