Use universal DBI for cDAC debugging - #5942
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4c34245d-758e-44f8-a284-9e2fb9a62d3d
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dbgshim’s cDAC debugging path to load a “universal” DBI (mscordbi_universal) alongside the bundled cDAC (mscordaccore_universal), and ensures the universal DBI is included in the DbgShim native NuGet package when cDAC packaging is enabled.
Changes:
- Package
mscordbi_universalinto theMicrosoft.Diagnostics.DbgShimruntime-native assets whenPackageWithCDacistrue. - Introduce
UNIVERSAL_DBI_MODULE_NAME_Wand switch the bundled DBI resolution for the cDAC path tomscordbi_universal. - Update header commentary to reflect bundling expectations (with a suggested clarification).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/dbgshim/pkg/Microsoft.Diagnostics.DbgShim.props | Packs mscordbi_universal next to dbgshim and the cDAC in runtime-specific native assets when PackageWithCDac is enabled. |
| src/dbgshim/debugshim.h | Adds the universal DBI module name constant and updates the bundling comment (with suggested clarification). |
| src/dbgshim/debugshim.cpp | Changes the bundled DBI resolution for the cDAC debugging path to load mscordbi_universal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hoyosjs
enabled auto-merge (squash)
July 28, 2026 19:38
noahfalk
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled cDAC path needs a DBI that owns its PAL.
mscordbi_universalfor cDAC debugging.