[feature/caching-rework] Centralize build planning - #2207
Conversation
Replace ad hoc cache checks with graph-based planning shared by matrix generation, build execution, and stale-image detection. Add composable policies, explicit actions, and causal explanations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d9f1ac1-4713-44b4-a6ba-17cb095984f6
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d9f1ac1-4713-44b4-a6ba-17cb095984f6
| .ToDictionary( | ||
| // SAFETY: PlatformInfo is checked in the Where clause above. | ||
| item => targetsByPlatform[item.Platform.PlatformInfo!], | ||
| item => new PublishedImage( | ||
| targetsByPlatform[item.Platform.PlatformInfo!], | ||
| item.Platform, | ||
| item.SharedTags) |
There was a problem hiding this comment.
This would break if there are multiple platforms across multiple images that point to the same Dockerfile. This would only happen in a scenario like we once had when we support multi-platform manifest lists across Windows and Linux. In that scenario, we had one manifest image for that multi-platform and another for the multi-arch Debian tag, both tags pointing to the same Debian Dockerfile. That would cause a duplicate key exception to occur here. We don't currently have such a configuration but wanted to point it out.
| "Build plan for {BuildTarget}: {Action}. {Reason}", | ||
| item.Target.DisplayName, | ||
| item.Decision.Action, | ||
| item.Decision.Reason); |
There was a problem hiding this comment.
Because BuildReason is recursively nested and we're relying on the logger's default implementation of calling ToString, this results in bunch of nested output, not flattened.
Example:
Build plan for runtime (...): BuildImage. BuildReason { Message = "Dependency 'runtime-deps (...)' must build., CausedBy = BuildReason { Message = Base image 'mcr.microsoft.com/dotnet/runtime:8.0' changed from 'sha256:old' to 'sha256:new'., CausedBy = } }
This PR centralizes build planning and policies across multiple separate commands. The design is not perfect as-is but I would like to work on improving it incrementally.
Design
The design centers around three new types:
BuildGraph,BuildPlanner, andIBuildPolicy.A
BuildGraphrepresents the relationships between the images in the manifest.The
BuildPlannertakes theBuildGraphin combination with anIBuildPolicyand uses it to determine what actions need to be taken.classDiagram direction LR class BuildCommand { } class GenerateBuildMatrixCommand { } class GetStaleImagesCommand { } class BuildTarget { } class BuildGraph { +Targets +Parents +Children +SharedBuildTargets } class BuildPlanner { +CreatePlanAsync(graph, imageInfo, policy) } class IBuildPolicy { } class BuildPlanItem { +Target +Action +Reasons +PublishedImage } class BuildAction { NoAction UsePublishedImage PublishExistingImage BuildImage } class BuildReason { +Message +Cause } class PublishedImage { +Source +Image +SharedTags } BuildCommand --> BuildGraph : creates GenerateBuildMatrixCommand --> BuildGraph : creates GetStaleImagesCommand --> BuildGraph : creates BuildCommand --> BuildPlanner : executes build plan GenerateBuildMatrixCommand --> BuildPlanner : uses for trimming GetStaleImagesCommand --> BuildPlanner : checks for stale images BuildGraph *-- BuildTarget BuildPlanner --> BuildGraph BuildPlanner --> IBuildPolicy : evaluates BuildPlanner --> BuildPlanItem : produces BuildPlanItem --> BuildTarget BuildPlanItem --> BuildAction BuildPlanItem *-- BuildReason BuildPlanItem --> PublishedImage PublishedImage --> BuildTarget : metadata sourceBuild policies
There are multiple "policies" that we check images against to determine what actions to take. Previously, all these checks were strewn about the codebase and not managed centrally anywhere.
The
CompositeBuildPolicycombines multiple different build policies into one that we can pass to the build planner.classDiagram direction LR class IBuildPolicy { +EvaluateAsync(context) BuildPolicyResult } class BuildPolicyContext { +BuildGraph Graph +BuildTarget Target +PublishedImages } class BuildPolicyResult { +BuildAction Action +BuildReason[] Reasons } class CompositeBuildPolicy { } class AlwaysBuildPolicy { } class MissingPublishedImagePolicy { } class TagSetChangedPolicy { } class DockerfileChangedPolicy { } class BaseImageChangedPolicy { } class ImageDigestCache { } class IGitService { } IBuildPolicy <|.. CompositeBuildPolicy IBuildPolicy <|.. AlwaysBuildPolicy IBuildPolicy <|.. MissingPublishedImagePolicy IBuildPolicy <|.. TagSetChangedPolicy IBuildPolicy <|.. DockerfileChangedPolicy IBuildPolicy <|.. BaseImageChangedPolicy IBuildPolicy --> BuildPolicyContext : input IBuildPolicy --> BuildPolicyResult : output CompositeBuildPolicy o-- IBuildPolicy : combines BuildPolicyResult --> BuildAction BuildPolicyResult *-- BuildReason BuildPolicyContext --> BuildGraph BuildPolicyContext --> BuildTarget BuildPolicyContext --> PublishedImage BaseImageChangedPolicy --> ImageDigestCache DockerfileChangedPolicy --> IGitService