Improve CI scan duplicate detection#7667
Open
svick wants to merge 1 commit into
Open
Conversation
Replace the nonexistent Build Analysis attachment with the GitHub check and require verbatim searches for complete test identifiers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d555b634-18ce-458d-a831-096e0b0c87b3
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ML.NET CI scan playbook/instructions to improve known-issue deduplication by switching from a nonexistent AzDO Build Analysis attachment to the actionable GitHub “Build Analysis” check output, and by tightening issue-search guidance for underscore-delimited test identifiers.
Changes:
- Replaces the prior AzDO
Build_Analysis_KnownIssues_v1attachment guidance with a GitHub Checks API (gh api .../commits/{sha}/check-runs) approach. - Clarifies dedup behavior: treat Build Analysis matches as a positive-only suppression signal; treat misses as inconclusive and continue searching.
- Requires searching complete underscore-delimited test method identifiers verbatim before deriving shorter stems.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/skills/ci-scan/references/playbook.md | Updates the Step 5 dedup procedure to incorporate the Build Analysis GitHub check as a positive-only signal and to continue exact searches after misses. |
| .github/skills/ci-scan/references/ci-scan.instructions.md | Replaces outdated Build Analysis attachment guidance with a GitHub check-runs query, and adds explicit guidance to search full underscore-delimited test identifiers verbatim. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ML.NET CI scanner instructions were modeled on dotnet/runtime and copied its claim that Arcade publishes a
Build_Analysis_KnownIssues_v1AzDO attachment. Investigation found no producer or retained machinelearning build containing that attachment; all 20 available definition 167 builds returned an empty attachment collection.Build Analysis results are available instead through the
Build AnalysisGitHub check on the build's source commit. The scanner should use positive issue links from that check as dedup evidence, while treating misses as inconclusive because large rendered reports can be truncated.The copied search guidance also lacked a rule to preserve complete underscore-delimited test identifiers. In a real ML.NET example, searching
AutoMLExperiment_return_current_best_trial_when_ct_is_canceled_with_trial_completed_Asyncfinds KBE #7418, while the shortened stem returns no results.Changes
Validation
Build Analysischeck 88824261755.Build_Analysis_KnownIssues_v1references remain under.github.Corresponding runtime change: dotnet/runtime#131312
cc: @kotlarmilos
Note
This pull request description was generated with GitHub Copilot.