Fix ichEnd offset bug in DoubleParser when input has leading whitespace#7668
Open
jelinekdev wants to merge 2 commits into
Open
Fix ichEnd offset bug in DoubleParser when input has leading whitespace#7668jelinekdev wants to merge 2 commits into
jelinekdev wants to merge 2 commits into
Conversation
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7181
Fixes the whitespace handling in
DoubleParser.Parsewhen the input contains leading whitespace.TryParsereturnsichEndrelative to the sliced span. The subsequent validation compares it against the original span, which can incorrectly returnResult.Extrafor valid inputs such as" 1.234 ".This change adjusts
ichEndback to the original span before validating the remaining characters.Added unit tests covering:
double)float)