Repository navigation
Fix mobile NavBar dropdown stacking and label the GitHub link - #99
Merged
Merged
Conversation
- Give NavMenu's dropdown panel z-10. Each NavMenu wrapper is `relative`, so in the stacked mobile menu the menu buttons following an open dropdown painted over its panel. - Show the gitHubTitle text next to a smaller GitHub icon in the collapsed mobile menu, so the link reads like the other nav entries. The desktop layout is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 95.44% 95.45% +0.01%
==========================================
Files 34 34
Lines 351 352 +1
Branches 123 124 +1
==========================================
+ Hits 335 336 +1
Misses 4 4
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the
NavBarin the collapsed mobile menu:NavMenuwrapper isrelative, and the openMenuItemspanel had no z-index. With several dropdowns stacked vertically on mobile, the menu buttons after the open dropdown (white text) painted over its panel. The panel now getsz-10. The storybook didn't show this because its only dropdown is followed by plainNavItemlinks. It does show up in the DraCor frontend, which has Corpora, Documentation and Tools dropdowns in a row.gitHubTitletext (default "GitHub") next to a smaller icon, so it reads like the other nav entries. This matches the current dracor.org production site. Desktop still shows the large icon only.🤖 Generated with Claude Code