Repository navigation
Add optional colours to packing items - #19
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughItems now support an optional colour that can be added, edited, and cleared. Adding and packing items uses colour when matching duplicates. CSV import and export preserve colour values and accept older CSV data without a colour column. ChangesItem colours
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The colour-edit behavior does not violate the documented duplicate rules. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 5 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Introduced a new ColourPicker component for selecting item colours. - Updated ItemCard and BaggageCard components to utilize ColourPicker for colour management. - Added predefined colour presets and support for custom hex input. - Enhanced styling for colour-related UI elements in App.css. - Updated integration tests to reflect changes in colour selection functionality.
Add optional colour pickers to Quick Add, custom items, and existing item cards. Matching colours merge when adding or packing duplicates; different colours remain separate.
Store colours as lowercase six-digit hex strings, or null when no colour is selected. Preserve them in local storage and CSV export/import. Older lists and CSV files without colours load with null; blank or invalid imported colours also become null.
Closes #17.
Validation: TypeScript check, ESLint, all 38 tests, and production build pass. Four full-app integration tests cover adding and packing duplicates, custom item editing and persistence across reloads, real CSV download/upload round-trips, and legacy data normalization. App components, state updates, and PapaParse run together; browser storage/download APIs are supplied by the test environment.