Repository navigation
Split spin_wait into std and no_std versions - #18
Merged
Merged
Conversation
Instead of one function that mixes cfg! in its condition, a cfg attribute on the yield, and a min(3) that only the no_std path needs, define spin_wait once for each configuration. Behavior is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16.
spin_waitmixed three mechanisms: a runtimecfg!in theif, a#[cfg]onyield_nowthat leaves an emptyelsewithoutstd, and a.min(3)that does nothing on thestdpath. This defines it once for each configuration:main, plus the saturating counter from Make the crate no_std, with std as a default feature #16.No behavior change.
cargo testpasses with and without default features, andthumbv6m-none-eabiwithportable-atomicstill checks.🤖 Generated with Claude Code