Repository navigation
Conversation
append-only-vec 0.1.9 is no_std unless its std feature is on, so depend on it without default features and forward std and portable-atomic to it. That lets the no_std CI checks of intern and intern32 build. They then showed that intern32 itself used std: two PhantomData paths and a size_of_val now come from core, and a leftover debugging println in deep_size_of_interned is gone. intern32 also did not enable the append-only-vec dependency or the container module it uses, so it could not build without intern; it does now. The CI checks of intern32, intern and arena on their own now add spin: without std each needs spin for its mutex, and says so in a compile_error, so they could never pass as written. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 1.70 CI jobs no longer build: parking_lot_core 0.9.12 (through dashmap, for the arc feature) and zmij (through serde_json) both need Rust 1.71. criterion 0.4 was a dev-dependency used only by the get_container bench, and its dependencies need Rust 1.80, so cargo test could not build on 1.71 either. It now sits behind a benchmarks feature, as on the scaling-0.9 branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without it, --features intern32 failed to compile with an unresolved deepsize crate, which the benchmarks need. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The benchmarks feature now enables criterion, whose dependencies do not build on docs.rs's nightly. docs.rs and the CI docs job used all-features, so both failed; list the features instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 80.61% 80.22% -0.39%
==========================================
Files 11 11
Lines 1852 1851 -1
==========================================
- Hits 1493 1485 -8
- Misses 359 366 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
droundy
added a commit
that referenced
this pull request
Oct 22, 2026
Master gained the MSRV, optional-criterion, docs-features and append-only-vec 0.1.9 changes (#69) and the Arena intern_with helper (#68), which this branch had also made. Keep master's versions of those, and this branch's scaling, internment_old and benchmarks feature on top; Arena::intern keeps its explicit lifetime. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on master has been failing since before #68 (the #67 merge failed the same way). This PR fixes it.
Rust 1.70 jobs:
parking_lot_core(throughdashmap) andzmij(throughserde_json) now need Rust 1.71. This raisesrust-versionand both CI matrices to 1.71.cargo teston 1.71 still couldn't build, because thecriteriondev-dependency needs 1.80.criterionnow sits behind a newbenchmarksfeature, which only theget_containerbench requires.Check (stable): This job was being cancelled by fail-fast, which hid failures in its later steps:
--features intern32,internandarenawithoutstdhit the crate's owncompile_error!requiringstdorspin. Those steps now addspin.intern32didn't build withoutstd. It usedstd::paths, adeepsizebound that wasn't feature-gated, and thecontainermodule andappend-only-vecwithout enabling them.Docs: Making
criterionoptional means--all-featureswould build it on nightly, whereclapfails. docs.rs and the CI docs job now list their features explicitly instead.Three of the four commits are cherry-picked from the
scaling-0.9branch (#66): a3d4fd8, 2a44d7a and 31ba3bb. The docs commit's message and comment were adjusted to fit master. The MSRV commit mirrors that branch's approach, but itsbenchmarksfeature only enablescriterionhere. That should keep the later merge ofscaling-0.9simple.Tested locally on 1.71.0 and stable:
Checkstep passes. Thex86_64-unknown-noneandthumbv6m-none-eabisteps were run on the host target, since those targets aren't installed here.cargo testpasses on 1.71.cargo test --all-features -- --test-threads=1passes.cargo docpasses with-Dwarnings.Not fixed here:
benches/bench.rswas already failing to build on master, because thearc-internerdependency it uses isn't enabled by thebenchfeature. No CI job builds the benches.🤖 Generated with Claude Code